Bug 274969
| Summary: | Two files include <Timer.h> instead of "Timer.h" | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Francisco Tolmasky <tolmasky> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Mac (Apple Silicon) | ||
| OS: | macOS 14 | ||
Francisco Tolmasky
Both "WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h" and "WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h" use "#include <Timer.h>" instead of "#include "Timer.h"". They seem to be the only two instances of using <> to do a peer search. As far as I can tell there is no specific reason for this, that is to say, it is not a workaround for finding the wrong Timer.h or something. I have changed them to "Timer.h" and it compiled fine. The current use of "<Timer.h>" is causing issues when I am trying to include these files somewhere else. You get the following error:
error: 'Timer.h' file not found with <angled> include; use "quotes" instead
35 | #include <Timer.h>
| ^~~~~~~~~
| "Timer.h"
If there is no reason for using "Timer.h", can I submit a PR changing to use "Timer.h"?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
@Francisco - I think it would be good to submit PR and get feedback. :-)
EWS
Committed 279621@main (838cb152e878): <https://commits.webkit.org/279621@main>
Reviewed commits have been landed. Closing PR #29376 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/129119819>