Bug 274894
| Summary: | [CMake][GLib] Propagate unified build setting to make-dist script | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | CMake | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=266755 | ||
Adrian Perez
The Tools/Scripts/make-dist script gained an --unified/-u command line
flag in 272404@main so we could check the value of ENABLE_UNIFIED_BUILDS
and pass it accordingly. Then using build-webkit to generate releases
like this:
Tools/Scripts/build-webkit --wpe --makeargs=distcheck --no-unified-builds
Tools/Scripts/build-webkit --wpe --makeargs=distcheck --unified-builds
would also result in doing the build from the generated tarball unified
or not depending on the CMake setting and whether --[no-]unified-builds
was used with build-webkit.
The main motivation for this is that we typically care about non-unified
builds for stable releases, but we may want to skip checking them for
development releases which are cut from the “main” branch (specially when
the build is tricky to fix), and this makes it easier to choose what the
script should do.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/29299
EWS
Committed 279509@main (5dfbc67f91ea): <https://commits.webkit.org/279509@main>
Reviewed commits have been landed. Closing PR #29299 and removing active labels.