Bug 27489

Summary:

cpplint's parse_argument should not exit even if no files are specified

Product:

WebKit

Reporter:

Shinichiro Hamaji <hamaji>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch v1	levin: review+

Shinichiro Hamaji

Reported 2009-07-21 01:20:33 PDT

run-webkit-lint script will use parse_argument() function. As the script will lint the current diff by default, we should not exit even if no files are specified.

Attachments
Patch v1 (3.25 KB, patch) 2009-07-21 01:22 PDT, Shinichiro Hamaji	levin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Shinichiro Hamaji

Comment 1 2009-07-21 01:22:20 PDT

Created attachment 33156 [details] Patch v1 --- 3 files changed, 17 insertions(+), 7 deletions(-)

David Levin

Comment 2 2009-07-21 03:07:03 PDT

Committed as http://trac.webkit.org/changeset/46161

Note You need to log in before you can comment on or make changes to this bug.