Bug 274762

Summary:	Fix render tree construction when inlines are inserted in reverse after a block in a continuation
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Layout and Rendering	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, karlcow, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2024-05-27 18:39:49 PDT

Hi Team,

While going through Blink's commit, I came across another potential merge and failing test case:

Test Case: https://jsfiddle.net/a0txqehw/

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/6ac676e5e68e3271321b9c8236192b6a530d055e

It seems to be fixed, if changed L156 to following in RenderTreeBuilder::Inline::insertChildToContinuation:

if (childInline == beforeChildAncestor->isInline() || (beforeChild && beforeChild->isInline()))

__

Just raising so we can fix it.

Thanks!

Comment 1 Radar WebKit Bug Importer 2024-05-27 18:40:13 PDT

<rdar://problem/128826228>

Comment 2 Ahmad Saleem 2024-05-27 19:53:33 PDT

PR - https://github.com/WebKit/WebKit/pull/29162

Comment 3 EWS 2024-05-28 19:40:23 PDT

Committed 279422@main (4af8f052cd4f): <https://commits.webkit.org/279422@main>

Reviewed commits have been landed. Closing PR #29162 and removing active labels.