Bug 27469

Summary: Make it harder to misuse try* allocation routines
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: Web Template FrameworkAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
a patch
oliver: review-
a correct patch none

Oliver Hunt
Reported 2009-07-20 16:32:39 PDT
I'm paranoid so i'd like to make it harder to avoid null checking the results of try* allocation functions.
Attachments
a patch (22.68 KB, patch)
2009-07-20 17:38 PDT, Oliver Hunt 		oliver: review-
DetailsFormatted DiffDiff
a correct patch (22.61 KB, patch)
2009-07-20 17:45 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2009-07-20 17:38:56 PDT
Created attachment 33126 [details] a patch
Oliver Hunt
Comment 2 2009-07-20 17:39:22 PDT
Comment on attachment 33126 [details] a patch whoops, bad patch
Oliver Hunt
Comment 3 2009-07-20 17:45:40 PDT
Created attachment 33127 [details] a correct patch
Gavin Barraclough
Comment 4 2009-07-20 19:42:04 PDT
Comment on attachment 33127 [details] a correct patch Please rename 'Maybe' to 'PossiblyNull', abarth ftw!
Oliver Hunt
Comment 5 2009-07-20 21:36:24 PDT
Fix landed in 46153
Oliver Hunt
Comment 6 2009-08-11 22:26:53 PDT
This was rolled out ue to windows bustage
Eric Seidel (no email)
Comment 7 2009-08-13 14:47:18 PDT
Comment on attachment 33127 [details] a correct patch Clearing barraclough's review flag to not confuse us humans.
Oliver Hunt
Comment 8 2009-08-13 14:55:41 PDT
This was relanded in r47092 with appropriate fixes
Note You need to log in before you can comment on or make changes to this bug.