Bug 274601
| Summary: | [PlayStation] Fix build break after 279061@main | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jigen Zhou <jigen.zhou> |
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | commit-queue, fujii.hironori, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 274615, 274616 | ||
| Bug Blocks: | |||
Jigen Zhou
03:44:29 D:/merging-webkit/build-job/Source/WTF\wtf/text/UniquedStringImpl.h:34:7: error: 'suppress' attribute only applies to variables and statements
03:44:29 34 | class SUPPRESS_REFCOUNTED_WITHOUT_VIRTUAL_DESTRUCTOR UniquedStringImpl : public StringImpl {
03:44:29 | ^
03:44:29 D:/merging-webkit/build-job/Source/WTF\wtf/Compiler.h:512:5: note: expanded from macro 'SUPPRESS_REFCOUNTED_WITHOUT_VIRTUAL_DESTRUCTOR'
03:44:29 512 | IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_ATTRIBUTE("webkit.RefCntblBaseVirtualDtor")
03:44:29 | ^
03:44:29 D:/merging-webkit/build-job/Source/WTF\wtf/Compiler.h:470:73: note: expanded from macro 'IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_ATTRIBUTE'
03:44:29 470 | #define IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_ATTRIBUTE(warning, ...) [[clang::suppress]]
03:44:29 | ^
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
Did bug#274484 fix it?
EWS
Committed 279233@main (1d67aa3bb515): <https://commits.webkit.org/279233@main>
Reviewed commits have been landed. Closing PR #28998 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/128636573>
WebKit Commit Bot
Re-opened since this is blocked by bug 274616
Ryosuke Niwa
This fix is redundant. It was already fixed in 279094@main.
Jigen Zhou
(In reply to Ryosuke Niwa from comment #5)
> This fix is redundant. It was already fixed in 279094@main.
Sorry, I didn't notice the fix.