Bug 27460

Summary:

WebCore/platform/FileSystem.h needs to include wtf/Platform.h before using the PLATFORM macro

Product:

WebKit

Reporter:

Dumitru Daniliuc <dumi>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	fishd: review-

Description Dumitru Daniliuc 2009-07-20 13:07:14 PDT

FileSystem.h includes wtf/Platform.h after using the PLATFORM macro. Depending on where FileSystem.h is included, PLATFORM might or might not be defined. In general though, wtf/Platform.h should be included at the very top of FileSystem.h.

Comment 1 Dumitru Daniliuc 2009-07-20 13:20:22 PDT

Created attachment 33101 [details]
patch

Comment 2 Darin Fisher (:fishd, Google) 2009-07-20 13:29:46 PDT

Comment on attachment 33101 [details]
patch

This is not correct.  The implication of this change is that some .cpp file is not including config.h.

Comment 3 Dumitru Daniliuc 2009-07-20 15:50:33 PDT

The problem is on the Chromium side.