Bug 274534
Summary: | [Xcode] WK_WORKSPACE_DIR build setting computed incorrectly when WebKit is checked out in a directory named "Source" | ||
---|---|---|---|
Product: | WebKit | Reporter: | Elliott Williams <emw> |
Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Elliott Williams
In WebKitProjectPaths.xcconfig, WK_WORKSPACE_DIR is computed by walking up the file hierarchy and looking for a "Source" or "Tools" directory to indicate the root directory of the repo. But it doesn't terminate when it finds a match.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/128549939>
EWS
Committed 279224@main (d67f50b1bb68): <https://commits.webkit.org/279224@main>
Reviewed commits have been landed. Closing PR #28926 and removing active labels.