Bug 274478
| Summary: | REGRESSION(276827@main): Large animated images may not animate all the frames | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Images | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=273457 https://bugs.webkit.org/show_bug.cgi?id=265363 |
||
Said Abou-Hallawa
1. Open https://l.engage.covetruspharmacy.com/custloads/1046323924/md_147976.gif
Result: On a slow network, only a few frames of this image will animate.
2. Wait a few seconds
3. Close the window
4. Open the same link again
Result: In the second time all the frames of the image will be animated.
5. Empty the caches (empty the web site data)
6. Close the window
6. Open the same link again
Result: On a slow network, only a few frames of this image will animate.
This is a regression of the BitmapImage refactoring 276827@main. See bug 273457. We used to postpone animating the image till loading the image is complete. The number of frames can only be known for sure when the loading the encoded data is complete. If we start animating before we get all the data, we may end up animating a small set of the image frames.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Said Abou-Hallawa
rdar://127697287
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/28863
EWS
Committed 279090@main (fab9c4ba90cc): <https://commits.webkit.org/279090@main>
Reviewed commits have been landed. Closing PR #28863 and removing active labels.