Bug 274416

Summary: AX: must call WTF::switchOn on a copy of AXPropertyValueVariant
Product: WebKit Reporter: Dominic Mazzoni <dm_mazzoni>
Component: AccessibilityAssignee: Dominic Mazzoni <dm_mazzoni>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Dominic Mazzoni
Reported 2024-05-20 13:47:21 PDT
WTF::switchOn takes an rvalue reference (&&) so if we In https://bugs.webkit.org/show_bug.cgi?id=273959 I changed a call to WTF::switchOn to avoid an extra copy. For some types it was resulting in moving the type away from the property map. Many isolated tree tests failed as a result. Let's revert this to fix things, but it'd be nice to figure out a solution that's less fragile and doesn't require a copy just to access a value from the property map.
Attachments
Patch (1.68 KB, patch)
2024-05-20 13:51 PDT, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2024-05-20 16:02 PDT, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-05-20 13:47:34 PDT
<rdar://problem/128416654>
Dominic Mazzoni
Comment 2 2024-05-20 13:51:44 PDT
Created attachment 471453 [details] Patch
Tyler Wilcock
Comment 3 2024-05-20 14:05:17 PDT
Comment on attachment 471453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471453&action=review r+ with commit message fixed > COMMIT_MESSAGE:7 > +WTF::switchOn takes an rvalue reference (&&) so if we Seems like this sentence is missing some words :)
Tyler Wilcock
Comment 4 2024-05-20 14:05:35 PDT
> but it'd be nice to figure out a solution that's less fragile and doesn't require a copy just to access a value from the property map. Indeed!
Dominic Mazzoni
Comment 5 2024-05-20 16:02:50 PDT
Created attachment 471456 [details] Patch
EWS
Comment 6 2024-05-20 18:27:38 PDT
Committed 279028@main (8764515d00e9): <https://commits.webkit.org/279028@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471456 [details].
Note You need to log in before you can comment on or make changes to this bug.