Bug 274257
| Summary: | [GStreamer] Silence GstVideoFrame leaks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <philn> |
| Component: | Platform | Assignee: | Philippe Normand <philn> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cgarcia, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 274467, 274468 | ||
| Bug Blocks: | |||
Philippe Normand
.
the gst_video_frame_map done from "auto videoFrame = makeUnique<GstMappedFrame>(buffer, &videoInfo, GST_MAP_READ);" has no corresponding unmap...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philippe Normand
CCing the author of this.
Carlos Garcia Campos
This is not specific to Skia, the problem is that ImageDecoderGStreamer is always created with two references, because it's added to a global Vector<RefPtr<ImageDecoderGStreamer>> for some reason. That vector is kept alive until teardownGStreamerImageDecoders() is called, which is supposed to be called on web process exit.
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/28782
EWS
Committed 279052@main (f5bc5e55ae85): <https://commits.webkit.org/279052@main>
Reviewed commits have been landed. Closing PR #28782 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/128454923>
Philippe Normand
Reopened Bugzilla.
incomplete fix, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=274467.
EWS
Committed 279063@main (ff0ee80363c4): <https://commits.webkit.org/279063@main>
Reviewed commits have been landed. Closing PR #28854 and removing active labels.
Philippe Normand
.
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/28905
EWS
Committed 279190@main (f6f7e5b1258f): <https://commits.webkit.org/279190@main>
Reviewed commits have been landed. Closing PR #28905 and removing active labels.