Bug 274257 - [GStreamer] Silence GstVideoFrame leaks
Summary: [GStreamer] Silence GstVideoFrame leaks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on: 274467 274468
Blocks:
  Show dependency tree / graph
 
Reported: 2024-05-16 07:02 PDT by Philippe Normand
Modified: 2024-05-23 05:35 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2024-05-16 07:02:26 PDT 
.

the gst_video_frame_map done from "auto videoFrame = makeUnique<GstMappedFrame>(buffer, &videoInfo, GST_MAP_READ);" has no corresponding unmap...
Comment 1 Philippe Normand 2024-05-16 07:36:13 PDT 
CCing the author of this.
Comment 2 Carlos Garcia Campos 2024-05-17 02:30:55 PDT 
This is not specific to Skia, the problem is that ImageDecoderGStreamer is always created with two references, because it's added to a global Vector<RefPtr<ImageDecoderGStreamer>> for some reason. That vector is kept alive until teardownGStreamerImageDecoders() is called, which is supposed to be called on web process exit.
Comment 3 Philippe Normand 2024-05-20 03:11:47 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28782
Comment 4 EWS 2024-05-21 02:56:43 PDT 
Committed 279052@main (f5bc5e55ae85): <https://commits.webkit.org/279052@main>

Reviewed commits have been landed. Closing PR #28782 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2024-05-21 02:57:15 PDT 
<rdar://problem/128454923>
Comment 6 Philippe Normand 2024-05-21 07:35:18 PDT 
Reopened Bugzilla.
incomplete fix, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=274467.
Comment 7 EWS 2024-05-21 10:28:32 PDT 
Committed 279063@main (ff0ee80363c4): <https://commits.webkit.org/279063@main>

Reviewed commits have been landed. Closing PR #28854 and removing active labels.
Comment 8 Philippe Normand 2024-05-22 01:24:38 PDT 
.
Comment 9 Philippe Normand 2024-05-22 02:06:11 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28905
Comment 10 EWS 2024-05-23 05:35:45 PDT 
Committed 279190@main (f6f7e5b1258f): <https://commits.webkit.org/279190@main>

Reviewed commits have been landed. Closing PR #28905 and removing active labels.