Bug 27423

Summary: Remove some outdated S60 platform specific code
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed patch ! zecke: review+

Laszlo Gombos
Reported 2009-07-19 12:35:42 PDT
The definition of PLATFORM(S60) is ambiguous; S60 should not be defined for the sole reason of __SYMBIAN32__ being defined. The PLATFORM(S60) guard is not used in the source tree, so to avoid further confusion I would propose to remove the PLATFROM(S60) definition and use PLATFORM(SYMBIAN) instead. I confirmed that this change has no impact on the current Symbian port of QtWebKit.
Attachments
Proposed patch ! (1.59 KB, patch)
2009-07-19 12:43 PDT, Laszlo Gombos 		zecke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-07-19 12:43:26 PDT
Created attachment 33049 [details] Proposed patch ! Also removed WTF_USE_SYMBIAN_UNICODE, it is no longer used.
Simon Hausmann
Comment 2 2009-07-20 02:50:54 PDT
Landed in r46115
Note You need to log in before you can comment on or make changes to this bug.