Bug 274064
| Summary: | [Win] Use SystemV ABI for C++ entrypoints for JS LLInt | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ian Grunert <ian.grunert> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fujii.hironori, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Windows 10 | ||
Ian Grunert
clang-cl gives us the option of changing a function to use the SystemV ABI:
https://clang.llvm.org/docs/AttributeReference.html#sysv-abi
By using this on functions on the C++ / JIT boundaries, we can use the same codepaths for function calls and the same register mappings between Windows and Linux / Mac / BSD.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ian Grunert
Pull request: https://github.com/WebKit/WebKit/pull/28723
EWS
Committed 278967@main (8f1711cf5f78): <https://commits.webkit.org/278967@main>
Reviewed commits have been landed. Closing PR #28723 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/128339579>