Bug 27401

Summary: webkit-tools-completion.sh has two typos and sorting issues.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed fix. mrowe: review+

David Levin
Reported 2009-07-17 18:27:14 PDT
There is a --dif (instead of --diff) for prepare-ChangeLog and a -clean (instead of --clean) for build-webkit. In addition, a nice rule to follow when laying out items is that if ordering doesn't matter, then sort them and the script doesn't currently do that for the many lists in it.
Attachments
Proposed fix. (4.60 KB, patch)
2009-07-17 18:30 PDT, David Levin 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-07-17 18:30:54 PDT
Created attachment 32997 [details] Proposed fix.
David Levin
Comment 2 2009-07-17 18:37:17 PDT
Committed as http://trac.webkit.org/changeset/46076
Note You need to log in before you can comment on or make changes to this bug.