Bug 27401 - webkit-tools-completion.sh has two typos and sorting issues.
Summary: webkit-tools-completion.sh has two typos and sorting issues.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-17 18:27 PDT by David Levin
Modified: 2009-07-17 18:37 PDT (History)
0 users

See Also:

Attachments
Proposed fix. (4.60 KB, patch)
2009-07-17 18:30 PDT, David Levin 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-07-17 18:27:14 PDT 
There is a --dif (instead of --diff) for prepare-ChangeLog and a -clean (instead of --clean) for build-webkit.

In addition, a nice rule to follow when laying out items is that if ordering doesn't matter, then sort them and the script doesn't currently do that for the many lists in it.
Comment 1 David Levin 2009-07-17 18:30:54 PDT 
Created attachment 32997 [details]
Proposed fix.
Comment 2 David Levin 2009-07-17 18:37:17 PDT 
Committed as http://trac.webkit.org/changeset/46076