Bug 273995
| Summary: | Replace unique frame names with frame identifiers in the history controller | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Charlie Wolfe <charliew> |
| Component: | History | Assignee: | Charlie Wolfe <charliew> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Charlie Wolfe
With site isolation, unique frame names should not be used to identify frames. This patch replaces most of their usage in the history controller with frame identifiers. We cannot remove unique frame names from HistoryItem because logic in FrameLoader::loadURLIntoChildFrame requires us to match current frames with frames from a previous page. Unique frame names are also still used from session state and history test output.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/127870100>
Charlie Wolfe
Pull request: https://github.com/WebKit/WebKit/pull/28385
EWS
Committed 278629@main (686240cb98d8): <https://commits.webkit.org/278629@main>
Reviewed commits have been landed. Closing PR #28385 and removing active labels.