Bug 273974
| Summary: | UNPACK_COLORSPACE_CONVERSION_WEBGL should only be used from texImage2D and texSubImage2D calls taking HTMLImageElement | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gerald Squelart <g_squelart> |
| Component: | WebGL | Assignee: | Gerald Squelart <g_squelart> |
| Status: | ASSIGNED | ||
| Severity: | Normal | CC: | dino, kbr, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 272015 | ||
Gerald Squelart
According to the specs https://registry.khronos.org/webgl/specs/latest/1.0/#PIXEL_STORAGE_PARAMETERS :
> UNPACK_COLORSPACE_CONVERSION_WEBGL of type unsigned long
> If set to BROWSER_DEFAULT_WEBGL, then the browser's default colorspace conversion is applied during subsequent texImage2D and texSubImage2D calls taking HTMLImageElement. [...]
> If the TexImageSource is an ImageBitmap, then [this] parameter will be ignored.
But looking at the source code in WebGLRenderingContextBase.cpp, I see that it's used in `WebGLRenderingContextBase::texImageImpl`, which is called from `WebGLRenderingContextBase::texImageSource(..., HTMLImageElement& source)` (as expected), but also from others that take `ImageBitmap`, `HTMLCanvasElement`, etc.
rdar://127580661
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Gerald Squelart
Pull request: https://github.com/WebKit/WebKit/pull/28371