Bug 273968

Summary: AX: AXObjectCache::postPlatformNotification should take an AccessibilityObject not an AXCoreObject.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, darin, dmazzoni, ews-watchlist, jcraig, ross.kirsling, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Andres Gonzalez
Reported 2024-05-09 12:52:50 PDT
.
Attachments
Patch (23.78 KB, patch)
2024-05-09 13:00 PDT, Andres Gonzalez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (23.78 KB, patch)
2024-05-09 14:04 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (22.97 KB, patch)
2024-05-10 08:18 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-05-09 12:53:01 PDT
<rdar://problem/127833247>
Andres Gonzalez
Comment 2 2024-05-09 13:00:56 PDT
Created attachment 471344 [details] Patch
Andres Gonzalez
Comment 3 2024-05-09 14:04:47 PDT
Created attachment 471346 [details] Patch
Darin Adler
Comment 4 2024-05-09 20:53:32 PDT
Comment on attachment 471346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471346&action=review > Source/WebCore/accessibility/AXObjectCache.h:598 > + void postPlatformNotification(const AccessibilityObject&, AXNotification); How about having this take a reference and not a const reference? Could avoid the const_cast and I think it makes logical sense either way.
Andres Gonzalez
Comment 5 2024-05-10 08:18:28 PDT
Created attachment 471359 [details] Patch
Andres Gonzalez
Comment 6 2024-05-10 08:20:15 PDT
(In reply to Darin Adler from comment #4) > Comment on attachment 471346 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=471346&action=review > > > Source/WebCore/accessibility/AXObjectCache.h:598 > > + void postPlatformNotification(const AccessibilityObject&, AXNotification); > > How about having this take a reference and not a const reference? Could > avoid the const_cast and I think it makes logical sense either way. Yes, done, thanks!
EWS
Comment 7 2024-05-11 09:34:21 PDT
Committed 278653@main (3ced9c0227fc): <https://commits.webkit.org/278653@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471359 [details].
Ross Kirsling
Comment 8 2024-05-11 21:47:00 PDT
Comment on attachment 471359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471359&action=review > Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp:91 > + protectedObject = notifyChildrenSelectionChange(protectedObject.get()); This gives `no known conversion from 'WebCore::AXCoreObject *' to 'const WTF::RefPtr<WebCore::AccessibilityObject>'`.
Ross Kirsling
Comment 9 2024-05-12 18:23:17 PDT
(In reply to Ross Kirsling from comment #8) > Comment on attachment 471359 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=471359&action=review > > > Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp:91 > > + protectedObject = notifyChildrenSelectionChange(protectedObject.get()); > > This gives `no known conversion from 'WebCore::AXCoreObject *' to 'const > WTF::RefPtr<WebCore::AccessibilityObject>'`. Fixing in https://github.com/WebKit/WebKit/pull/28453.
Note You need to log in before you can comment on or make changes to this bug.