Bug 273852

Summary: [JSC] Use std::span::data in super hot function
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: dpino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=273838

Description Yusuke Suzuki 2024-05-07 17:01:20 PDT 
...
Comment 1 Radar WebKit Bug Importer 2024-05-07 17:01:39 PDT 
<rdar://problem/127703218>
Comment 2 Yusuke Suzuki 2024-05-07 17:03:06 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28262
Comment 3 EWS 2024-05-07 18:54:24 PDT 
Committed 278486@main (ed761c32df61): <https://commits.webkit.org/278486@main>

Reviewed commits have been landed. Closing PR #28262 and removing active labels.
Comment 4 Diego Pino 2024-05-08 03:03:40 PDT 
Build bot 'GTK-Linux-64-bit-Release-Debian-Stable-Build' is failing after this change with the following build error:

https://build.webkit.org/#/builders/46/builds/39864

```
/home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/Source/JavaScriptCore/runtime/JSONObject.cpp:1124:89: internal compiler error: unexpected expression ‘static_cast<UnsignedType>('\"')’ of kind static_cast_expr
 1124 |                 constexpr auto quoteMask = WTF::splatBulk(static_cast<UnsignedType>('"'));
      |                                                   
```

GCC version is 11.4.0.
Comment 5 Diego Pino 2024-05-08 03:04:41 PDT 
Re-opening for pull request https://github.com/webkit/webkit/pull/28285
Comment 6 EWS 2024-05-08 09:02:11 PDT 
Committed 278511@main (1ee00a2309c0): <https://commits.webkit.org/278511@main>

Reviewed commits have been landed. Closing PR #28285 and removing active labels.