Bug 27375

Summary: [Chromium] Need a DOM_STORAGE guard in DerivedSourcesAllInOne.cpp
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eroman, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 dglazkov: review+

Jeremy Orlow
Reported 2009-07-17 09:59:45 PDT
In https://bugs.webkit.org/show_bug.cgi?id=27360 I added Storage.cpp and StorageEvent.cpp. Unfortunately, until later this afternoon, DOM_STORAGE is not turned on by default in Chromium, and so these two files are never generated. This breaks the compile. There are no other instances of guards in the file, which puzzles me..but I think adding guards is the right way to go about this.
Attachments
v1 (1.61 KB, patch)
2009-07-17 10:43 PDT, Jeremy Orlow 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2009-07-17 10:10:19 PDT
Currently testing a fix.
Jeremy Orlow
Comment 2 2009-07-17 10:43:53 PDT
Created attachment 32957 [details] v1 In https://bugs.webkit.org/show_bug.cgi?id=27360 I added Storage.cpp and StorageEvent.cpp. Unfortunately, until later this afternoon, DOM_STORAGE is not turned on by default in Chromium, and so these two files are never generated. This breaks the compile. There are no other instances of guards in the file, which puzzles me..but I think adding guards is the right way to go about this.
Dimitri Glazkov (Google)
Comment 3 2009-07-17 10:47:44 PDT
Comment on attachment 32957 [details] v1 r=me
Dimitri Glazkov (Google)
Comment 4 2009-07-17 11:02:25 PDT
Landed as http://trac.webkit.org/changeset/46041.
Note You need to log in before you can comment on or make changes to this bug.