Bug 273711

Summary:

AX: Moving testing only attributes in WebAccessibilityObjectWrapperMac.mm to attributeValueForTesting

Product:

WebKit

Reporter:

Tyler Wilcock <tyler_w>

Component:

Accessibility

Assignee:

Tyler Wilcock <tyler_w>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Tyler Wilcock

Reported 2024-05-03 14:31:30 PDT

This is a tiny performance improvement and code cleanup.

Attachments
Patch (6.87 KB, patch) 2024-05-03 14:37 PDT, Tyler Wilcock	no flags	Details Formatted Diff Diff
Patch (6.87 KB, patch) 2024-05-03 16:10 PDT, Tyler Wilcock	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-05-03 14:31:39 PDT

<rdar://problem/127512021>

Tyler Wilcock

Comment 2 2024-05-03 14:37:49 PDT

Created attachment 471274 [details] Patch

chris fleizach

Comment 3 2024-05-03 14:57:58 PDT

Comment on attachment 471274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471274&action=review > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2321 > + return [NSNumber numberWithBool: backingObject->isIndeterminate()]; should fix this spacing hBool: backingObjec > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2323 > + if ([attributeName isEqualToString:@"AXIsMultiSelectable"]) we're sure all of these are not used by VO?

Tyler Wilcock

Comment 4 2024-05-03 16:10:23 PDT

Created attachment 471276 [details] Patch

Tyler Wilcock

Comment 5 2024-05-03 16:11:08 PDT

(In reply to chris fleizach from comment #3) > Comment on attachment 471274 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=471274&action=review > > > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2321 > > + return [NSNumber numberWithBool: backingObject->isIndeterminate()]; > > should fix this spacing > hBool: backingObjec Fixed! > > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2323 > > + if ([attributeName isEqualToString:@"AXIsMultiSelectable"]) > > we're sure all of these are not used by VO? Yep, just re-confirmed none of these are used by VoiceOver or any other assistive technology.

EWS

Comment 6 2024-05-04 07:41:07 PDT

Committed 278375@main (06293e14f619): <https://commits.webkit.org/278375@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471276 [details].

Note You need to log in before you can comment on or make changes to this bug.