Bug 273576
| Summary: | Add assert in JSObject::getOwnNonIndexPropertySlot | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcus Plutowski <marcus_plutowski> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mark.lam, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Marcus Plutowski
rdar://127365044
Currently `JSObject::getOwnNonIndexPropertySlot` checks to make sure the type of the cell matches, but does not make sure that the PropertyAttributes include Accessor; for debugging purposes it would be helpful to add a check for that inside the function so that the issue shows up right away rather than somewhere downstream.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marcus Plutowski
Pull request: https://github.com/WebKit/WebKit/pull/28005
EWS
Committed 278518@main (108a035df97d): <https://commits.webkit.org/278518@main>
Reviewed commits have been landed. Closing PR #28005 and removing active labels.
Marcus Plutowski
Re-opening for pull request https://github.com/WebKit/WebKit/pull/28414
Mark Lam
We decided that ttps://github.com/WebKit/WebKit/pull/28414 is not worth doing. The previous commit is sufficient.