Bug 27352

Summary:

Video size sometimes jumps just after the video starts loading

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

WebCore Misc.

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Patch, changelog	darin: review+

Simon Fraser (smfr)

Reported 2009-07-16 14:36:04 PDT

With hardware-accelerated video, sometimes the size jumps just after the video starts loading. It's an ordering problem where we end up creating the video rendering before the intrinsic size is known.

Attachments
Patch, changelog (3.04 KB, patch) 2009-07-16 14:39 PDT, Simon Fraser (smfr)	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2009-07-16 14:39:52 PDT

Created attachment 32893 [details] Patch, changelog

Darin Adler

Comment 2 2009-07-16 14:41:29 PDT

Comment on attachment 32893 [details] Patch, changelog > + bool readyForRendering() const; I think it would be slightly better to call this isReadyForRendering for two reasons. 1) "ready" is verb as well as an adjective. 2) Without the "is", the function seems like it might be the caller saying we are ready, rather than asking. r=me

Simon Fraser (smfr)

Comment 3 2009-07-16 18:33:04 PDT

http://trac.webkit.org/changeset/45986

Note You need to log in before you can comment on or make changes to this bug.