Bug 273206

Summary: AX: Remove several unused word, sentence, and paragraph position functions
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tyler Wilcock
Reported 2024-04-24 11:58:37 PDT
...
Attachments
Patch (16.64 KB, patch)
2024-04-24 12:01 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (17.73 KB, patch)
2024-04-24 16:47 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (18.57 KB, patch)
2024-04-25 10:56 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-04-24 11:58:48 PDT
<rdar://problem/127000726>
Tyler Wilcock
Comment 2 2024-04-24 12:01:52 PDT
Created attachment 471108 [details] Patch
Tyler Wilcock
Comment 3 2024-04-24 16:47:10 PDT
Created attachment 471118 [details] Patch
chris fleizach
Comment 4 2024-04-24 17:51:21 PDT
Comment on attachment 471118 [details] Patch Could have swore we had Mac functions with markers to use these. Why and when were they added? Did we use to have a marker interface?
Tyler Wilcock
Comment 5 2024-04-25 10:52:40 PDT
(In reply to chris fleizach from comment #4) > Comment on attachment 471118 [details] > Patch > > Could have swore we had Mac functions with markers to use these. Why and > when were they added? Did we use to have a marker interface? These existed before 2008, but the git history doesn't go back any farther: https://github.com/WebKit/WebKit/commit/8486f1fe2dbeef8ae18aa9198fa56eebd3543a01#diff-e8db8bb19347472225640770719ab1678c0a95100df8cf27d1beb3a536717dcc These functions stopped being called in these commits: https://github.com/WebKit/WebKit/commit/9510dea2c8571c731e1450a64ebb77a4b415dabc https://github.com/WebKit/WebKit/commit/8d97d59fcdf545e5cb25fbebb472e49b233256f2 https://github.com/WebKit/WebKit/commit/c67290aee69c9fd2fa709067c3f902e1d34ef912 (Commit titles are implement word / sentence / paragraph functionality using TextIterator) The attributes that were associated with these functions still exist and are used, but now have a different implementation, e.g.: if ([attribute isEqualToString:AXPreviousSentenceStartTextMarkerForTextMarkerAttribute]) return (id)[self textMarkerForTextMarker:textMarker atUnit:TextUnit::PreviousSentenceStart];
Tyler Wilcock
Comment 6 2024-04-25 10:56:47 PDT
Created attachment 471132 [details] Patch
EWS
Comment 7 2024-04-25 17:29:22 PDT
Committed 278019@main (ffd9b9de8c8a): <https://commits.webkit.org/278019@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471132 [details].
Note You need to log in before you can comment on or make changes to this bug.