Bug 27309

Summary: Local variable in instantiateV8Object shadows function parameter
Product: WebKit Reporter: James Hawkins <jhawkins>
Component: WebCore Misc.Assignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch which removes the local variable
abarth: review+
Patch2: modified the changelog abarth: review+

James Hawkins
Reported 2009-07-15 12:00:43 PDT
v8::Local<v8::Object> V8DOMWrapper::instantiateV8Object(V8Proxy* proxy, ... ... if (!proxy) V8Proxy* proxy = V8Proxy::retrieve(); proxy is declared as a local variable in the if clause, which shadows the function parameter of the same name. This is a typo. I will attach a patch which fixes this issue.
Attachments
Patch which removes the local variable (1.26 KB, patch)
2009-07-15 12:02 PDT, James Hawkins 		abarth: review+
DetailsFormatted DiffDiff
Patch2: modified the changelog (1.28 KB, patch)
2009-07-15 12:11 PDT, James Hawkins 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Hawkins
Comment 1 2009-07-15 12:02:53 PDT
Created attachment 32797 [details] Patch which removes the local variable
Adam Barth
Comment 2 2009-07-15 12:07:00 PDT
Comment on attachment 32797 [details] Patch which removes the local variable + No test required as this change does not affect layout. You should say that no test is required because this change does not change our behavior. The LayoutTests test much more than just layout. :)
James Hawkins
Comment 3 2009-07-15 12:11:41 PDT
Created attachment 32800 [details] Patch2: modified the changelog
Adam Barth
Comment 4 2009-07-15 12:14:14 PDT
Comment on attachment 32800 [details] Patch2: modified the changelog Thanks!
Adam Barth
Comment 5 2009-07-15 21:53:25 PDT
Will land.
Adam Barth
Comment 6 2009-07-15 22:04:10 PDT
Sending WebCore/ChangeLog Sending WebCore/bindings/v8/V8DOMWrapper.cpp Transmitting file data .. Committed revision 45965.
Note You need to log in before you can comment on or make changes to this bug.