Bug 27295

Summary: The Qt DRT pops up message boxes when javascript execution takes too long
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 26886    
Attachments:
Description Flags
patch to re-implement shouldInterruptJavaScript() in Qt DRT manyoso: review+

Simon Hausmann
Reported 2009-07-15 05:46:55 PDT
Created attachment 32779 [details] patch to re-implement shouldInterruptJavaScript() in Qt DRT Tests like fast/js/try-catch-crash.html take a long time with debug builds and the interpreter and may result in a message box popping up. Qt DRT should re-implement QWebPage::shouldInterruptJavaScript() and return false, to avoid the message boxes. The run-webkit-tests counterpart takes care of the timeout handling.
Attachments
patch to re-implement shouldInterruptJavaScript() in Qt DRT (1.27 KB, patch)
2009-07-15 05:46 PDT, Simon Hausmann 		manyoso: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2009-07-15 05:51:54 PDT
Landed in r45906
Note You need to log in before you can comment on or make changes to this bug.