WebInspector: show last opened panel when invoking inspector.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

Currently Elements panel is being shown on open, no matter which one user was using before.

[Pavel Feldman]

Created attachment 32715 [details]
patch

[Timothy Hatcher]

Comment on attachment 32715 [details]
patch

> +          if (lastActivePanelSetting.type() == Setting::StringType) {
> +              m_showAfterVisible = specialPanelForJSName(lastActivePanelSetting.string());
> +          }

No need for the curly braces.

[Pavel Feldman]

Sending        WebCore/ChangeLog
Sending        WebCore/inspector/InspectorController.cpp
Sending        WebCore/inspector/InspectorController.h
Sending        WebCore/inspector/InspectorController.idl
Sending        WebCore/inspector/front-end/inspector.js
Transmitting file data .....
Committed revision 45861.

[Joseph Pecoraro]

After this was applied I got a small error when I open the Inspector with the ⌥⌘C shortcut that opens the console.

TypeError: Result of expression 'WebInspector.currentPanel' [undefined] is not a valid argument for 'in'.

That comes from Console.js, at approx line 87:
http://trac.webkit.org/browser/trunk/WebCore/inspector/front-end/Console.js#L59

  function animationFinished()
  {
      if ("updateStatusBarItems" in WebInspector.currentPanel)
          WebInspector.currentPanel.updateStatusBarItems();
      WebInspector.currentFocusElement = this.promptElement;
      delete this._animating;
  }

I think that has to do with the fact that a "this.currentPanel" was deleted in this patch.

[Joseph Pecoraro]

Eek, opening with ⌥⌘I I am getting an empty error messages from:
InspectorController.storeLastActivePanel(panelName);

[Pavel Feldman]

Created attachment 32766 [details]
patch

[Pavel Feldman]

Created attachment 32767 [details]
patch

[Pavel Feldman]

Created attachment 32768 [details]
patch

[Pavel Feldman]

Sending        WebCore/ChangeLog
Sending        WebCore/inspector/InspectorController.cpp
Sending        WebCore/inspector/InspectorController.idl
Transmitting file data ...
Committed revision 45899.

[Keishi Hattori]

This error seems to happen because [WebInspector showConsole] firing before m_frontend is set causes m_showAfterVisible to be overridden from CurrentPanel to ConsolePanel. I'm not sure but maybe adding m_showConsoleAfterVisible would be a fix?

[Pavel Feldman]

Created attachment 32847 [details]
patch

Special case ConsolePanel opening.

[Eric Seidel (no email)]

Comment on attachment 32847 [details]
patch

If this is closed as fixed, nothing should be marked for review.