Bug 272552

Summary:

REGRESSION(272801@main): CustomEvent.target is not set when dispatching event

Product:

WebKit

Reporter:

grahams

Component:

JavaScriptCore

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

ahmad.saleem792, a_protyasha, cdumez, karlcow, rniwa, webkit-bug-importer

Priority:

Keywords:

BrowserCompat, InRadar

Version:

Safari 17

Hardware:

All

OS:

All

URL:

https://codepen.io/graham_saunders/pen/jORKGJe

Bug Depends on:

267188

Bug Blocks:

Attachments:

Description	Flags
rendering in safari, firefox, chrome	none
Reduction	none

grahams

Reported 2024-04-11 14:04:39 PDT

The latest Webkit release (affecting Safari v17.4) is not setting the target and currentTarget attributes of a customEvent. Reproduction: https://codepen.io/graham_saunders/pen/jORKGJe Testing on <= v17.3 works as expected.

Attachments
rendering in safari, firefox, chrome (919.17 KB, image/png) 2024-04-11 17:45 PDT, Karl Dubost	no flags	Details
Reduction (199 bytes, text/html) 2024-04-11 22:11 PDT, Ryosuke Niwa	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Karl Dubost

Comment 1 2024-04-11 17:45:14 PDT

Created attachment 470876 [details] rendering in safari, firefox, chrome currentTarget is null in the 3 browsers. target and srcElement are different: * Firefox and Chrome: <input id="name" name="name"> * Safari: null Note that Firefox has also originalTarget and explicitOriginalTarget Tested in Safari Technology Preview 17.4 19619.1.8.1 Firefox Nightly 126.0a1 12624.4.11 Google Chrome Canary 125.0.6413.0 6413.0

Radar WebKit Bug Importer

Comment 2 2024-04-11 17:46:17 PDT

<rdar://problem/126311287>

Karl Dubost

Comment 3 2024-04-11 17:55:40 PDT

https://searchfox.org/wubkat/rev/8ce70fa03821ea1c7a19a3913730ffe6b8a522ed/Source/WebCore/dom/Event.cpp#126 https://searchfox.org/wubkat/rev/8ce70fa03821ea1c7a19a3913730ffe6b8a522ed/Source/WebCore/dom/CustomEvent.cpp#50

Karl Dubost

Comment 4 2024-04-11 19:05:22 PDT

In Safari 16.1 on Ventura 13 I get target and srcElement initialized to <input id="name" name="name"> and currentTarget to null.

Karl Dubost

Comment 5 2024-04-11 19:52:26 PDT

Regression range gives me: https://commits.webkit.org/compare/272803@main...272798@main I have the feeling it was broken by Bug 267188 https://github.com/WebKit/WebKit/commit/490b4fdda464141c8eedb0ec367dbf76c6077a77

Ryosuke Niwa

Comment 6 2024-04-11 22:11:35 PDT

Created attachment 470882 [details] Reduction

Ryosuke Niwa

Comment 7 2024-04-11 22:54:31 PDT

Pull request: https://github.com/WebKit/WebKit/pull/27184

EWS

Comment 8 2024-04-12 12:39:28 PDT

Committed 277435@main (5b488a0a1b57): <https://commits.webkit.org/277435@main> Reviewed commits have been landed. Closing PR #27184 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.