Bug 272529
| Summary: | [results.webkit.org] Fetch missing range commit on dashboard | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jonathan Bedard
Users can specify a "before_ref" argument to display a previous version of the dashboard. In 277252@main, we added this ability. It turns out, though, that the dashboard won't display correctly unless the provided ref can be converted to a timestamp, which can only happen if the provided ref is within the CommitBank. That's often the case (because we define the CommitBank based on the builds we found), but it's possible for the ref to be just outside the range of known commits. If we could explicitly add a commit to the CommitBank, we can fix this edge case.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/126275308>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/27144
EWS
Committed 278202@main (a71b5c17fafc): <https://commits.webkit.org/278202@main>
Reviewed commits have been landed. Closing PR #27144 and removing active labels.