Bug 272380
| Summary: | [WPE] REGRESSION(277190@main): build broken when using NEON filters | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Miguel Gomez <magomez> |
| Component: | WPE WebKit | Assignee: | Przemyslaw Gorszkowski <pgorszkowski> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, darin |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Miguel Gomez
277190@main changed the API to access a PixelBuffer's bytes in this way:
- uint8_t* bytes() const { return m_bytes; }
- size_t sizeInBytes() const { return m_sizeInBytes; }
+ std::span<uint8_t> bytes() const { return m_bytes; }
The NEON filters weren't updated with this change, so the build is broken when trying to use them.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Darin Adler
Not surprising. Code not built by EWS so it will break!
Darin Adler
Happy to review a patch to fix this.
Przemyslaw Gorszkowski
Pull request: https://github.com/WebKit/WebKit/pull/27089
EWS
Committed 277365@main (edc1bf6b0c8a): <https://commits.webkit.org/277365@main>
Reviewed commits have been landed. Closing PR #27089 and removing active labels.