Bug 272319
| Summary: | [build.webkit.org] Forcing a build with a hash fails for WebKitGTK and WPE builders | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> |
| Component: | New Bugs | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Diego Pino
Forcing a build with a hash fails for WebKitGTK and WPE builders. For instance:
https://build.webkit.org/#/builders/859/builds/7807
The build fails in the 'upload-file-to-s3' because the file 'minified-release.zip' doesn't exist.
The previous step in the build, 'archive-minified-built-product', executes the following command:
```
Tools/CISupport/built-product-archive --platform=wpe --release --minify archive
```
The command above produces 'WebKitBuild/release.zip', because minified archives are only supported in platforms Mac, iOS, tvOS and WatchOS (https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/built-product-archive#L250).
It seems the issue is in this line: https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/build-webkit-org/steps.py#L483. I think the creation of minified built products, and its consequent upload, should only happen if the current platform supports minified archives.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Diego Pino
Pull request: https://github.com/webkit/webkit/pull/26967
EWS
Committed 277235@main (e449d0612995): <https://commits.webkit.org/277235@main>
Reviewed commits have been landed. Closing PR #26967 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/126122339>