Bug 27231

Summary: REGRESSION: Clicking on nodes in the console should take you to the element in the DOM
Product: WebKit Reporter: Alexander Kellett <a>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue, joepeck, timothy
Priority: P2 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: https://bugs.webkit.org/show_bug.cgi?id=14368
Attachments:
Description Flags
proposed patch
timothy: review-
proposed patch 2 none

Description Alexander Kellett 2009-07-13 12:27:47 PDT
Clicking on any of the child nodes should take you to the DOM view and select
the clicked child.
Comment 1 Adam Roben (:aroben) 2009-07-13 12:32:01 PDT
This used to work. I think it broke in r41404: <http://trac.webkit.org/changeset/41404>.
Comment 2 Keishi Hattori 2009-10-21 11:17:16 PDT
Created attachment 41584 [details]
proposed patch

Clicking on a node in the console will select the node in the Elements panel.
Comment 3 Timothy Hatcher 2009-10-21 11:22:52 PDT
Comment on attachment 41584 [details]
proposed patch


> +        if (this.showInElementsPanel)

This can just be:

           if (this.treeOutline.showInElementsPanelEnabled)

Then you don't need all the propagation code.

> +            WebInspector.panels.elements.focusedDOMNode = this.representedObject;

We should switch to the Elements panel if it isn't visible too.
Comment 4 Keishi Hattori 2009-10-21 11:36:38 PDT
Created attachment 41591 [details]
proposed patch 2

I fixed the issues.
Comment 5 WebKit Commit Bot 2009-10-21 12:36:18 PDT
Comment on attachment 41591 [details]
proposed patch 2

Clearing flags on attachment: 41591

Committed r49917: <http://trac.webkit.org/changeset/49917>
Comment 6 WebKit Commit Bot 2009-10-21 12:36:21 PDT
All reviewed patches have been landed.  Closing bug.