Summary: | Change all Noncopyable inheriting to publicly inheriting | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||||
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, darin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 27248 | ||||||||
Attachments: |
|
Description
Zoltan Horvath
2009-07-13 11:28:41 PDT
Created attachment 32668 [details]
proposed patch
Comment on attachment 32668 [details] proposed patch > -struct OpaqueJSClassContextData : Noncopyable { > +struct OpaqueJSClassContextData : public Noncopyable { struct inheritance is already public, so this change is not needed. There are tons of other cases like this. Please don't make those changes since they aren't needed. Otherwise this seems fine. review- because I'd like to see the patch without the unneeded changes. Created attachment 32745 [details]
updated proposed patch
I've updated the patch and removed the unnecessary struct changes.
Landed in http://trac.webkit.org/changeset/45891. |