Bug 272063

Summary: AX: createObjectFromRenderer and accessibleNameForNode can take their arguments by reference rather than pointer
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, eric.carlson, ews-watchlist, glenn, jcraig, jer.noble, philipj, samuel_white, sergio, webkit-bug-importer, youssefdevelops, y_soliman
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tyler Wilcock
Reported 2024-04-02 17:19:44 PDT
Doing this saves null checks and makes intent more clear, as these functions or ones downstream from them either ASSERT non-null, or directly dereference the pointer without null checking.
Attachments
Patch (64.68 KB, patch)
2024-04-02 17:27 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (64.68 KB, patch)
2024-04-02 20:53 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-04-02 17:19:54 PDT
<rdar://problem/125813277>
Tyler Wilcock
Comment 2 2024-04-02 17:27:12 PDT
Created attachment 470736 [details] Patch
Tyler Wilcock
Comment 3 2024-04-02 20:53:54 PDT
Created attachment 470738 [details] Patch
EWS
Comment 4 2024-04-04 23:16:44 PDT
Committed 277096@main (7fe8ad6a3315): <https://commits.webkit.org/277096@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 470738 [details].
Note You need to log in before you can comment on or make changes to this bug.