WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
272063
AX: createObjectFromRenderer and accessibleNameForNode can take their arguments by reference rather than pointer
https://bugs.webkit.org/show_bug.cgi?id=272063
Summary
AX: createObjectFromRenderer and accessibleNameForNode can take their argumen...
Tyler Wilcock
Reported
2024-04-02 17:19:44 PDT
Doing this saves null checks and makes intent more clear, as these functions or ones downstream from them either ASSERT non-null, or directly dereference the pointer without null checking.
Attachments
Patch
(64.68 KB, patch)
2024-04-02 17:27 PDT
,
Tyler Wilcock
no flags
Details
Formatted Diff
Diff
Patch
(64.68 KB, patch)
2024-04-02 20:53 PDT
,
Tyler Wilcock
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-04-02 17:19:54 PDT
<
rdar://problem/125813277
>
Tyler Wilcock
Comment 2
2024-04-02 17:27:12 PDT
Created
attachment 470736
[details]
Patch
Tyler Wilcock
Comment 3
2024-04-02 20:53:54 PDT
Created
attachment 470738
[details]
Patch
EWS
Comment 4
2024-04-04 23:16:44 PDT
Committed
277096@main
(7fe8ad6a3315): <
https://commits.webkit.org/277096@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 470738
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug