Bug 272010
| Summary: | Allow using add_subdirectory with WebKit and/or JSC | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Theo Paris <theop> |
| Component: | CMake | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, bugs-noreply, don.olmstead, Hironori.Fujii, keith_miller, philn, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Theo Paris
I would like to make a PR that allows webkit's cmake build files to be added in another project using `add_subdirectory(WebKit).
This would make it easier to embed the entire webkit project as well as JSC individually.
See https://github.com/BunOSLabs/WebKit/commit/9b1c39fdee8a904460e73dbb5471c86caaef78f4 for the current changes I have come up with. So far I have changed CMAKE_{SOURCE,BINARY}_DIR to CMAKE_CURRENT_{SOURCE,BINARY}_DIR. Not sure if there's anything else that would be needed yet.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Theo Paris
Maybe adding a install target for JSC would be good as well.
Radar WebKit Bug Importer
<rdar://problem/126106710>
Keith Miller
I'm not opposed to a PR that does this. That said, since Apple ports don't use CMake it should probably be someone from a CMake port that reviews your change.