Bug 271997
| Summary: | Build failures in GeneratedSerializers.cpp in release builds with assertions enabled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebCore Misc. | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mcatanzaro, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=271337 | ||
Michael Catanzaro
Splitting this out from bug #271337. The condition for enabling assertions in ThreadSafeRefCounted.h (which checks NDEBUG) should match the comparable condition in RefCounted.h (which checks ASSERT_ENABLED). This will avoid tripping static assertions in GeneratedSerializers.cpp described in bug #271337, which was confusing a user who got a bit too inventive and tried enabling asserts in release builds.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/26700
Radar WebKit Bug Importer
<rdar://problem/126095861>
EWS
Committed 277248@main (2e1188405ef9): <https://commits.webkit.org/277248@main>
Reviewed commits have been landed. Closing PR #26700 and removing active labels.