[CSS-UI] Remove non-standard / invalid 'appearance' keywords

• Component: CSS
• Status: NEW ---

[Ahmad Saleem]

Hi Team,

While looking into Firefox specific failures, I noticed that we are failing following sub-tests:

WPT Test Case: https://wpt.fyi/results/css/css-ui/appearance-cssom-001.html%3Finclude=Invalid?label=master&label=experimental&aligned=&q=safari%3Afail

> Push-Button
> Square-Button
> Slider Vertical
> Slider Horizontal
> Apple Pay (might want to keep)

__

It seems to be not in specification - https://drafts.csswg.org/css-ui-4/#appearance-switching

So I am raising this bug to get input and track if we can remove them or workaround them.

If I just remove them (except Apple Pay - again might want to keep) from CSSProperties.json, it compiles and progress all tests except two related to 'Apple Pay'.

@Tim - any insight?

Thanks!

[Tim Nguyen (:ntim)]

I did a large clean up of the invalid ones a while back, but I think `-webkit-appearance: -apple-pay-button` is one we can't remove due to web compat. `-webkit-appearance: slider-vertical` is one we'd like to have a standard replacement for. 

Maybe Aditya can comment on the other ones.

[Aditya Keerthi]

I'm in favor of removing push-button / square-button from Safari. However, I'm aware of at least one internal app that relies on square-button.

I think the goal would be to remove behind a link check at some point.

[Aditya Keerthi]

I don't expect that there are any real compatibility issues here though, given the extremely rare usage (if any) on the web. Just an interop difference.

[Radar WebKit Bug Importer]

<rdar://problem/126000107>

[Karl Dubost]

Created attachment 470826 [details]
testcase

@Ahmad, 

This test case combines all input and appearance. 
This is basically non-sense but also helps determine if some of the values combinations have uncharacteristic behaviors.