Bug 271729
| Summary: | Rename *widthFor* functions | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vitor Roriz <vitor.roriz> |
| Component: | Text | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fantasai.bugs, Hironori.Fujii, vitor.roriz, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Vitor Roriz
We currently have:
1. widthForSimpleText
2. floatWidthForSimpleText
3. floatWidthForComplexText
These functions all do something similar but their names are a bit confusing, specially by the different meanings of the word "simple" here.
As previously described by @zallan with other words, the 3 function scale in level of complexity.
1. widthForSimpleText: does not use any width iterator, but has to pass "computeCanUseSimplifiedTextMeasuring" to be used.
2. floatWidthForSimpleText: It is used when we have a CodePath::Simple (calculated on FontCascade). It uses iterator WidthIterator
3. floatWidthForComplexText: It is used when we have a CodePath::Complex (calculated on FontCascade). It uses the ComplexTextControler, a more complete and slower iterator (supports kerning and ligaments, for example, which are currently not supported by WidthIterator).
We could probably have more explicit names for avoiding the confusion.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/125440731>
Vitor Roriz
Pull request: https://github.com/WebKit/WebKit/pull/26483
EWS
Committed 276716@main (31aadb040e32): <https://commits.webkit.org/276716@main>
Reviewed commits have been landed. Closing PR #26483 and removing active labels.