Bug 271696
| Summary: | [LibWebRTC][Linux] Make PulseAudio support optional | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <philn> |
| Component: | CMake | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Philippe Normand
ssia
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/26455
EWS
Committed 276708@main (b5a59471fd29): <https://commits.webkit.org/276708@main>
Reviewed commits have been landed. Closing PR #26455 and removing active labels.
Diego Pino
After this change the GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 bot was failing with the following build error:
```
CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:2172 (target_include_directories):
Cannot specify include directories for target "webrtc" which is not built
by this project.
CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:2173 (target_compile_options):
Cannot specify compile options for target "webrtc" which is not built by
this project.
```
'webrtc' is not defined yet at those lines, so they should be moved below in the file.
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/26500
EWS
Committed 276724@main (b81583054864): <https://commits.webkit.org/276724@main>
Reviewed commits have been landed. Closing PR #26500 and removing active labels.