Bug 27155

Summary:

bug in V8Custom invokeCallback which will crash on void callbacks

Product:

WebKit

Reporter:

John Gregg <johnnyg>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Fix the logic for computing the return value	levin: review+

John Gregg

Reported 2009-07-10 13:21:02 PDT

There's an incorrect check for an empty result in V8CustomVoidCallback.cpp.

Attachments
Fix the logic for computing the return value (1.25 KB, patch) 2009-07-10 16:05 PDT, John Gregg	levin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

John Gregg

Comment 1 2009-07-10 16:05:33 PDT

Created attachment 32589 [details] Fix the logic for computing the return value One-character fix to the logic for computing the return value.

David Levin

Comment 2 2009-07-13 02:14:27 PDT

Note for the future: Please avoid TABs (in the changelog).

David Levin

Comment 3 2009-07-13 02:34:27 PDT

Note You need to log in before you can comment on or make changes to this bug.