Bug 27153

Summary: Add delegate methods about focus and blur and state change
Product: WebKit Reporter: Greg Bolsinga <bolsinga>
Component: WebKit APIAssignee: Greg Bolsinga <bolsinga>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
This patch implements the needed changes
none
Remove the FrameView diff; it wasn't supposed to be there.
koivisto: review+
fixes up delegate method names eric: review+

Greg Bolsinga
Reported 2009-07-10 11:33:21 PDT
Some platforms need to be informed when focus and blur events occur. They may display chrome UI when these events occur.
Attachments
This patch implements the needed changes (7.65 KB, patch)
2009-07-10 12:04 PDT, Greg Bolsinga 		no flags
DetailsFormatted DiffDiff
Remove the FrameView diff; it wasn't supposed to be there. (7.08 KB, patch)
2009-07-10 12:08 PDT, Greg Bolsinga 		koivisto: review+
DetailsFormatted DiffDiff
fixes up delegate method names (3.20 KB, patch)
2009-08-10 13:12 PDT, Greg Bolsinga 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Greg Bolsinga
Comment 1 2009-07-10 12:04:19 PDT
Created attachment 32569 [details] This patch implements the needed changes
Greg Bolsinga
Comment 2 2009-07-10 12:08:39 PDT
Created attachment 32570 [details] Remove the FrameView diff; it wasn't supposed to be there.
Antti Koivisto
Comment 3 2009-07-10 13:12:17 PDT
Comment on attachment 32570 [details] Remove the FrameView diff; it wasn't supposed to be there. r=me
Greg Bolsinga
Comment 4 2009-07-10 13:32:58 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/html/HTMLFormControlElement.cpp M WebCore/html/HTMLFormControlElement.h M WebCore/loader/EmptyClients.h M WebCore/page/ChromeClient.h M WebKit/mac/ChangeLog M WebKit/mac/WebCoreSupport/WebChromeClient.h M WebKit/mac/WebCoreSupport/WebChromeClient.mm M WebKit/mac/WebView/WebUIDelegatePrivate.h Committed r45723
Adele Peterson
Comment 5 2009-07-10 13:36:39 PDT
The naming is a little weird. formDidFocus gets called when a form control was focused...and formDidFocus doesn't actually give any info about a particular form.
David Kilzer (:ddkilzer)
Comment 6 2009-07-10 15:18:58 PDT
Non-Mac build fix: <http://trac.webkit.org/changeset/45729>
Greg Bolsinga
Comment 7 2009-07-10 17:19:21 PDT
I named it this way following the style of: virtual void formStateDidChange(const Node*) What do you suggest?
Greg Bolsinga
Comment 8 2009-08-10 13:05:15 PDT
I see what you mean now. I'll attach a patch to clean up these delegate method names.
Greg Bolsinga
Comment 9 2009-08-10 13:12:41 PDT
Created attachment 34503 [details] fixes up delegate method names This is a new patch.
Eric Seidel (no email)
Comment 10 2009-08-11 22:44:01 PDT
Comment on attachment 34503 [details] fixes up delegate method names Looks fine.
Greg Bolsinga
Comment 11 2009-08-12 09:56:13 PDT
Thanks! Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/mac/ChangeLog M WebKit/mac/WebCoreSupport/WebChromeClient.mm M WebKit/mac/WebView/WebUIDelegatePrivate.h Committed r47119
Note You need to log in before you can comment on or make changes to this bug.