Summary: | Add delegate methods about focus and blur and state change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Greg Bolsinga <bolsinga> | ||||||||
Component: | WebKit API | Assignee: | Greg Bolsinga <bolsinga> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | adele, ddkilzer | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Greg Bolsinga
2009-07-10 11:33:21 PDT
Created attachment 32569 [details]
This patch implements the needed changes
Created attachment 32570 [details]
Remove the FrameView diff; it wasn't supposed to be there.
Comment on attachment 32570 [details]
Remove the FrameView diff; it wasn't supposed to be there.
r=me
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/html/HTMLFormControlElement.cpp M WebCore/html/HTMLFormControlElement.h M WebCore/loader/EmptyClients.h M WebCore/page/ChromeClient.h M WebKit/mac/ChangeLog M WebKit/mac/WebCoreSupport/WebChromeClient.h M WebKit/mac/WebCoreSupport/WebChromeClient.mm M WebKit/mac/WebView/WebUIDelegatePrivate.h Committed r45723 The naming is a little weird. formDidFocus gets called when a form control was focused...and formDidFocus doesn't actually give any info about a particular form. Non-Mac build fix: <http://trac.webkit.org/changeset/45729> I named it this way following the style of: virtual void formStateDidChange(const Node*) What do you suggest? I see what you mean now. I'll attach a patch to clean up these delegate method names. Created attachment 34503 [details]
fixes up delegate method names
This is a new patch.
Comment on attachment 34503 [details]
fixes up delegate method names
Looks fine.
Thanks! Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/mac/ChangeLog M WebKit/mac/WebCoreSupport/WebChromeClient.mm M WebKit/mac/WebView/WebUIDelegatePrivate.h Committed r47119 |