Bug 271525
| Summary: | [GTK] Build broken with USE_GBM=OFF | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=270979 | ||
Adrian Perez
In order to reproduce the issue:
./Tools/Scripts/build-webkit --gtk --cmakeargs=-DUSE_GBM=OFF
There are complaints about the <drm.h> header not found, plus the following:
/app/webkit/Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp:458:13: error: enumeration value 'EGLImage' not handled in switch [-Werror,-Wswitch]
switch (m_type) {
^~~~~~
/app/webkit/Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp:549:21: error: no member named 'setupBufferFormat' in 'WebKit::AcceleratedSurfaceDMABuf::SwapChain'
m_swapChain.setupBufferFormat(m_webPage.preferredBufferFormats(), m_isOpaque);
~~~~~~~~~~~ ^
/app/webkit/Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp:549:49: error: no member named 'preferredBufferFormats' in 'WebKit::WebPage'
m_swapChain.setupBufferFormat(m_webPage.preferredBufferFormats(), m_isOpaque);
~~~~~~~~~ ^
3 errors generated.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
This issue also affects the 2.44.0 release.
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/26379
EWS
Committed 276612@main (6af38ff93284): <https://commits.webkit.org/276612@main>
Reviewed commits have been landed. Closing PR #26379 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/125319499>
Adrian Perez
(In reply to Adrian Perez from comment #1)
> This issue also affects the 2.44.0 release.
FWIW, I have backported the patch to the 2.44 branch and it will be
part of the 2.44.1 release.