Bug 271376
| Summary: | [Skia] Check if glFence is available before using it | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | Platform | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, ujwal.koneru, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 268972 | ||
Carlos Garcia Campos
If not available we need to call GrDirectContext::submit() with GrSyncCpu=kYes
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/26241
EWS
Committed 276463@main (c4b3e26f6881): <https://commits.webkit.org/276463@main>
Reviewed commits have been landed. Closing PR #26241 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/125168348>
ujwal koneru
Hi Carlos,
I am checking in to playstation build failure for this change(https://build.webkit.org/#/builders/42/builds/39115). It looks like GL_SYNC_GPU_COMMANDS_COMPLETE is not available from gles3 headers.(gl3) In gl2 and gl2ext, I could not see the declaration at https://registry.khronos.org/OpenGL/api/GLES2/gl2ext.h
The declaration is available from gl3.h
https://registry.khronos.org/OpenGL/api/GLES3/gl3.h
I am wondering if the code was intended for gl3 check/apple extension support check(GL_SYNC_GPU_COMMANDS_COMPLETE_APPLE ). Please advise.
Carlos Garcia Campos
Yes, in that case I guess we need to include gl3.h in the #if USE(LIBEPOXY) else.