RESOLVED FIXED 271376
[Skia] Check if glFence is available before using it 
https://bugs.webkit.org/show_bug.cgi?id=271376
Summary [Skia] Check if glFence is available before using it
Carlos Garcia Campos
Reported 2024-03-21 05:03:53 PDT
If not available we need to call GrDirectContext::submit() with GrSyncCpu=kYes
Attachments
Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2024-03-21 05:54:27 PDT
Pull request: https://github.com/WebKit/WebKit/pull/26241
EWS
Comment 2 2024-03-21 08:11:03 PDT
Committed 276463@main (c4b3e26f6881): <https://commits.webkit.org/276463@main> Reviewed commits have been landed. Closing PR #26241 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-03-21 08:12:14 PDT
<rdar://problem/125168348>
ujwal koneru
Comment 4 2024-03-21 14:42:03 PDT
Hi Carlos, I am checking in to playstation build failure for this change(https://build.webkit.org/#/builders/42/builds/39115). It looks like GL_SYNC_GPU_COMMANDS_COMPLETE is not available from gles3 headers.(gl3) In gl2 and gl2ext, I could not see the declaration at https://registry.khronos.org/OpenGL/api/GLES2/gl2ext.h The declaration is available from gl3.h https://registry.khronos.org/OpenGL/api/GLES3/gl3.h I am wondering if the code was intended for gl3 check/apple extension support check(GL_SYNC_GPU_COMMANDS_COMPLETE_APPLE ). Please advise.
Carlos Garcia Campos
Comment 5 2024-03-31 09:41:37 PDT
Yes, in that case I guess we need to include gl3.h in the #if USE(LIBEPOXY) else.
Note You need to log in before you can comment on or make changes to this bug.