Bug 27134

Summary:

[V8] Make DOMWrapper interface more like JSC

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

arv, dglazkov, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch (renaming only)	none

Description Adam Barth 2009-07-09 16:11:50 PDT

In JSC you make a wrapper by saying toJS.  In V8, we have a bunch of different functions that do that.  We should unify them.  I've worked up a patch with the name V8DOMWrapper::wrap (soon to be followed with V8DOMWrapper::unwrap for the reverse operation).

Patch forthcoming.

Comment 1 Adam Barth 2009-07-09 16:19:53 PDT

Created attachment 32537 [details]
Patch (renaming only)

Comment 2 Eric Seidel (no email) 2009-07-09 17:17:56 PDT

Comment on attachment 32537 [details]
Patch (renaming only)

Why not just call them toJS like the JSC bindings?  And make them autogenerated like the JSC bindings?

Or is that the eventual plan?

Comment 3 Adam Barth 2009-07-09 17:37:17 PDT

That sound rocking.  Cancel the review and I'll do that instead.

Comment 4 Brian Burg 2014-12-16 00:48:07 PST

Closing some V8-related work items.