Bug 27122

Summary:

prepare-ChangeLog should decode HTML entities in short description

Product:

WebKit

Reporter:

Shinichiro Hamaji <hamaji>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hamaji, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1	none
Patch v2	none
Patch v3	mjs: review+

Shinichiro Hamaji

Reported 2009-07-09 10:25:01 PDT

When I ran ./WebKitTools/Scripts/prepare-ChangeLog --bug=25406 I've got -webkit-box-orient:horizontal doesn't work on <button> tag in ChangeLog. It is better to decode HTML entities.

Attachments
Patch v1 (1.45 KB, patch) 2009-07-09 10:27 PDT, Shinichiro Hamaji	no flags	Details Formatted Diff Diff
Patch v2 (1.80 KB, patch) 2009-07-09 12:47 PDT, Shinichiro Hamaji	no flags	Details Formatted Diff Diff
Patch v3 (2.04 KB, patch) 2009-07-09 13:03 PDT, Shinichiro Hamaji	mjs: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Shinichiro Hamaji

Comment 1 2009-07-09 10:27:04 PDT

Created attachment 32522 [details] Patch v1

Darin Adler

Comment 2 2009-07-09 12:07:54 PDT

Comment on attachment 32522 [details] Patch v1 Is the HTML::Entities package installed on everyone's system? Is it included with Mac OS X, for example?

Shinichiro Hamaji

Comment 3 2009-07-09 12:26:43 PDT

(In reply to comment #2) > (From update of attachment 32522 [details]) > Is the HTML::Entities package installed on everyone's system? Is it included > with Mac OS X, for example? Environments I checked (OSX 10.4, 10.5, Debian, Ubuntu, Cygwin) had the module. However, I've just noticed that perl-5.8.8 source package don't have the module so it seems not to be a part of standard. Should I implement it by myself? It would not difficult at all because we don't need all HTML entites but ones bugzilla use (maybe <>"'& I guess?).

Shinichiro Hamaji

Comment 4 2009-07-09 12:47:43 PDT

Created attachment 32527 [details] Patch v2

Shinichiro Hamaji

Comment 5 2009-07-09 12:53:03 PDT

Attached another patch which doesn't use HTML::Entities. I grepped bugzilla's source code and found xml_quote is the only function which has "'". So, I guessed that we don't need to decode &#[0-9a-f]{3}; style entities.

Shinichiro Hamaji

Comment 6 2009-07-09 13:03:27 PDT

Created attachment 32528 [details] Patch v3 Oops sorry. I forgot to add function declaration for decodeEntities.

Maciej Stachowiak

Comment 7 2009-07-09 20:07:28 PDT

Comment on attachment 32528 [details] Patch v3 r=me

David Levin

Comment 8 2009-07-13 02:37:39 PDT

Committed as http://trac.webkit.org/changeset/45799

Note You need to log in before you can comment on or make changes to this bug.