Bug 27115

Summary: bugzilla-tool: extract duplicate logging methods into a module
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1 aroben: review+

David Kilzer (:ddkilzer)
Reported 2009-07-09 05:50:57 PDT
Created attachment 32514 [details] Patch v1 Reviewed by NOBODY (OOPS!). * Scripts/bugzilla-tool: Removed error() and log() methods and added import of new logging module. * Scripts/modules/bugzilla.py: Ditto. Removed "import sys". * Scripts/modules/scm.py: Ditto. * Scripts/modules/logging.py: Added. (log): Added. (error): Added. Prefix error messages with "ERROR: ". --- 5 files changed, 60 insertions(+), 22 deletions(-)
Attachments
Patch v1 (4.85 KB, patch)
2009-07-09 05:50 PDT, David Kilzer (:ddkilzer) 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2009-07-09 09:32:59 PDT
Comment on attachment 32514 [details] Patch v1 I'm no Python expert, but this seems reasonable, and I'm sure you followed the example of the existing code. r=me
Eric Seidel (no email)
Comment 2 2009-07-09 14:39:49 PDT
Looks good.
David Kilzer (:ddkilzer)
Comment 3 2009-07-10 14:02:27 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/modules/bugzilla.py A WebKitTools/Scripts/modules/logging.py M WebKitTools/Scripts/modules/scm.py Committed r45725 M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py M WebKitTools/Scripts/modules/scm.py A WebKitTools/Scripts/modules/logging.py M WebKitTools/Scripts/bugzilla-tool r45725 = 6c272cc56dee4c1ae1c0dd23491efb1b1b86adbd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/45725
Note You need to log in before you can comment on or make changes to this bug.