Bug 270944
| Summary: | Drop Vector constructor taking a raw pointer and a size | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
Drop Vector constructor taking a raw pointer and a size and port call sites to the constructor taking a std::span instead.
This is work towards more widespread std::span adoption in WebKit, which has security benefits.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/25854
EWS
Committed 276220@main (7263d3ab5680): <https://commits.webkit.org/276220@main>
Reviewed commits have been landed. Closing PR #25854 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/124725283>
Diego Pino
Several build bots (Debian 11, Ubuntu 22.04) are failing after this change:
https://build.webkit.org/#/builders/992/builds/740
```
../../../Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp:91:28: error: ‘auto’ parameter not permitted in this context
91 | Vector<uint8_t> result(std::span { gcry_md_read(m_context->md, 0), digestLen });
| ^~~
```
These bots feature GCC10.2 and GCC11.4 respectively.
The original PR tackled several build errors reported by EWS JSC bots, but since JSC bots build with `--jsc-only` flag, likely many other changes were not addressed.